lkml.org 
[lkml]   [2004]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: MSEC_TO_JIFFIES is messed up...
On Wed, 12 May 2004, Ingo Molnar wrote:

>
> * Jeff Garzik <jgarzik@pobox.com> wrote:
>
> > >Woah, that's new. And wrong. The code in include/asm-i386/param.h that
> > >says:
> > > # define JIFFIES_TO_MSEC(x) (x)
> > > # define MSEC_TO_JIFFIES(x) (x)
> > >
> > >Is not correct. Look at kernel/sched.c for verification of this :)
> >
> >
> > Yes, that is _massively_ broken.
>
> why is it wrong?

For HZ == 1000 it's fine, even if it'd better to explicitly make it HZ
dependent and let the compiler to discard them.



- Davide

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:03    [W:0.091 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site