Messages in this thread | | | Date | Fri, 30 Apr 2004 22:48:04 -0700 | From | Greg KH <> | Subject | Re: [PATCH] 2.6 I2C epson 8564 RTC chip |
| |
On Thu, Apr 29, 2004 at 02:02:50PM +0200, stefan.eletzhofer@eletztrick.de wrote: > + if ( !buf || !client ) {
Can you clean up your exuberant use of spaces in 'if' statements, and function calls? It's not the proper kernel style.
> +DONE:
Lowercase please
> + if ( ret ) { > + if ( d ) kfree( d );
No need to check a pointer before sending it to kfree.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |