Messages in this thread | | | Date | Wed, 7 Apr 2004 11:39:17 +1000 | From | Nathan Scott <> | Subject | Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix |
| |
On Tue, Apr 06, 2004 at 11:54:41PM +0200, Andrea Arcangeli wrote: > > Christoph, I got no positive feedback yet for the alternate fix you > proposed and it's not obvious to my eyes (isn't good_pages going to be > screwed with your fix?), but I wanted to checkin a fix into CVS in the > meanwhile, so for now I've checked in my __GFP_NO_COMP fix that I'm sure > doesn't require any testing since it's obviously safe and it should > definitely fix the problem. This way you can also take your time for the > testing of your better fix. > > What's not clear to me about your fix is if it's really working safe > with good_pages being overdecremented (good_pages doesn't look just an > hint, there seems to be a valid reason you're doing the set_bit/test_bit > on page->private, no?).
Ignore the first part of that patch, it was misdirected (Christoph woulda gone through and put guards around all pagebuf page->private users; turns out the first change was unnecessary, and confusing ;).
cheers.
-- Nathan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |