Messages in this thread | | | Date | Wed, 7 Apr 2004 00:11:36 +0100 | From | viro@parcelfa ... | Subject | Re: [Patch] BME, noatime and nodiratime |
| |
On Tue, Apr 06, 2004 at 09:48:44PM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote:
> noatime/nodiratime: OK, but we still have direct modifications of i_atime > that need to be taken care of.
Particulary interesting one is in tty_io.c. There we 1) unconditionally touch i_atime on read() 2) do not touch it on write() 3) never mark the inode dirty.
Note that the last one means that doing stat() in a loop will sometimes give atime going backwards. We also completely ignore noatime here.
There are similar places in some other char drivers. Obvious step would be to have them do file_accessed() instead; however, I'd really like to hear the rationale for existing behaviour. Comments? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |