Messages in this thread | | | Date | Sat, 3 Apr 2004 11:27:55 +0200 | From | Francois Romieu <> | Subject | Re: [PATCH] Fix kernel lockup in RTL-8169 gigabit ethernet driver |
| |
Adam Nielsen <a.nielsen@optushome.com.au> : [...] > in the Realtek 8169 gigabit ethernet driver. Due to a logic error, > there is a loop in an interrupt handler that often goes infinite, thus > locking up the entire computer. The attached patch fixes the problem.
- until there is an explanation on _why_ this condition happens, this is a band-aid for an unexplained condition, not a fix for a "logic error" (it may have interesting performance effects though);
- the included comments may be ok in the bk repository but they do not really add anything to the driver itself;
- please avoid the "else break" in just one line;
- last change to this file found its way through the bk thing on 02/26/2004 but a set of changes for this driver is available 1) in -mm tree 2) in Jeff Garzik's -netdev patches 3) near my fridge. A patch addressing the same issue has been posted on l-k the 03/29/2004 as an answer to a remark made by Daniel Egger (feedback anyone ?). If you can wait until the whole thing is included, it will make my life easier;
- please Cc: netdev@oss.sgi.com for network related patches as well as jgarzik@pobox.com for network drivers related patches
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |