Messages in this thread | | | Date | Thu, 29 Apr 2004 18:02:54 +0200 | From | Vojtech Pavlik <> | Subject | Re: locking in psmouse |
| |
On Thu, Apr 29, 2004 at 11:58:30AM +0200, Pavel Machek wrote:
> > > psmouse-base.c does not have any locking. For example psmouse_command > > > could race with data coming from the mouse, resulting in problem. This > > > should fix it. > > > > Although I am not arguing that locking might be needed in psmouse module I > > am somewhat confused how it will help in case of data stream coming from the > > mouse... If mouse sent a byte before the kernel issue a command then it will > > be delivered by KBC controller and will be processed by the interrupt handler, > > probably messing up detection process. That's why as soon as we decide that > > the device behind PS/2 port is some kind of mouse we disable the stream mode.
Any PS/2 device is supposed to stop talking as soon as it gets a command until it's done with it. Supposed to. Namely USB Legacy emulation breaks this rule.
-- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |