Messages in this thread | | | Date | Tue, 27 Apr 2004 17:05:11 -0700 | From | William Lee Irwin III <> | Subject | Re: [PATCH] Fix cpu iterator on empty bitmask |
| |
On Wed, Apr 28, 2004 at 09:52:53AM +1000, Rusty Russell wrote: > Name: Fix cpumask iterator over empty cpu set > Status: Trivial > Can't use _ffs() without first checking for zero, and if bits beyond > NR_CPUS set it'll give bogus results. Use find_first_bit
I sent in something equivalent to this along with a number of other fixes (cpus_shift_right() leaking junk bits in in and cpus_weight() and cpus_empty() and cpus_equal() and the like not ignoring tails) and got a NAK since it clashes with something Paul Jackson's doing.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |