lkml.org 
[lkml]   [2004]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Return more useful error number when acls are too large
hi Andreas,

On Mon, Apr 26, 2004 at 12:27:58PM +0200, Andreas Gruenbacher wrote:
> Hello,
>
> could you please add this to mainline? Getting EINVAL when an acl
> becomes too large is quite confusing.
>
> if (acl) {
> if (acl->a_count > EXT2_ACL_MAX_ENTRIES)
> - return -EINVAL;
> + return -ENOSPC;

That seems an odd error code to change it to, since its not
related to the device running out of free space right? Maybe
use -E2BIG instead?

XFS has a similar check (different limit as you know), so is
also affected by this; could you update XFS at the same time
with whatever value gets chosen, if its not EINVAL? Or just
let me know what gets chosen & I'll fix it up later.

thanks.

--
Nathan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [W:0.044 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site