Messages in this thread Patch in this message | | | Date | Mon, 26 Apr 2004 14:57:17 -0700 | From | "Adrian Yee" <> | Subject | Re: [PATCH] 8139too not running s3 suspend/resume pci fix |
| |
Hi Felipe,
> IMHO, there's no problem in doing "pci_save_state (pdev, > tp->pci_state)" before the suspend code..but I'm more confortable with > leaving the set_power_state at the end of that path, since if the > interface is down, we don't want to leave it in cold state.
That makes sense. So something more like this:
--- drivers/net/8139too.c.orig 2004-04-26 14:53:04.715985134 -0700 +++ drivers/net/8139too.c 2004-04-26 14:53:50.373431714 -0700 @@ -2550,6 +2550,8 @@ static int rtl8139_suspend (struct pci_d void *ioaddr = tp->mmio_addr; unsigned long flags; + pci_save_state (pdev, tp->pci_state); + if (!netif_running (dev)) return 0; @@ -2568,7 +2570,6 @@ static int rtl8139_suspend (struct pci_d spin_unlock_irqrestore (&tp->lock, flags); pci_set_power_state (pdev, 3); - pci_save_state (pdev, tp->pci_state); return 0; } @@ -2579,9 +2580,9 @@ static int rtl8139_resume (struct pci_de struct net_device *dev = pci_get_drvdata (pdev); struct rtl8139_private *tp = dev->priv; + pci_restore_state (pdev, tp->pci_state); if (!netif_running (dev)) return 0; - pci_restore_state (pdev, tp->pci_state); pci_set_power_state (pdev, 0); rtl8139_init_ring (dev); rtl8139_hw_start (dev); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |