Messages in this thread Patch in this message | | | Date | Thu, 22 Apr 2004 12:33:06 +0200 | From | Pavel Machek <> | Subject | Re: b44 needs to reclaim its interrupt after swsusp |
| |
Hi!
> >@@ -1874,6 +1874,8 @@ > > b44_free_rings(bp); > > > > spin_unlock_irq(&bp->lock); > >+ > >+ free_irq(dev->irq, dev); > > return 0; > > } > > > >@@ -1887,6 +1889,9 @@ > > > > pci_restore_state(pdev, bp->pci_cfg_state); > > > >+ if (request_irq(dev->irq, b44_interrupt, SA_SHIRQ, dev->name, dev)) > >+ printk("b44: request_irq failed\n"); > >+ > > look ok, with minor nit: use KERN_xxx prefix in printk
Fixed, here's updated patch, please apply, Pavel
--- tmp/linux/drivers/net/b44.c 2004-04-22 12:25:36.000000000 +0200 +++ linux/drivers/net/b44.c 2004-04-22 12:20:48.000000000 +0200 @@ -1252,7 +1252,7 @@ } #if 0 -/*static*/ void b44_dump_state(struct b44 *bp) +void b44_dump_state(struct b44 *bp) { u32 val32, val32_2, val32_3, val32_4, val32_5; u16 val16; @@ -1875,6 +1875,8 @@ b44_free_rings(bp); spin_unlock_irq(&bp->lock); + + free_irq(dev->irq, dev); return 0; } @@ -1888,6 +1890,9 @@ pci_restore_state(pdev, bp->pci_cfg_state); + if (request_irq(dev->irq, b44_interrupt, SA_SHIRQ, dev->name, dev)) + printk(KERN_ERR PFX "%s: request_irq failed\n", dev->name); + spin_lock_irq(&bp->lock); b44_init_rings(bp); -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |