Messages in this thread | | | Date | Thu, 22 Apr 2004 11:36:45 -0700 | From | "David S. Miller" <> | Subject | Re: Large inlines in include/linux/skbuff.h |
| |
On Thu, 22 Apr 2004 17:56:46 +0300 Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> wrote:
> On Thursday 22 April 2004 03:47, James Morris wrote: > > On Wed, 21 Apr 2004, Denis Vlasenko wrote: > > > What shall be done with this? I'll make patch to move locking functions > > > into net/core/skbuff.c unless there is some reason not to do it. > > > > How will these changes impact performance? I asked this last time you > > posted about inlines and didn't see any response. > > Hard to say. We will lose ~2% to extra call/return instructions > but will gain 40kb of icache space.
He's asking you to test and quantify the performance changes that occur as a result of this patch, not to figure it out via calculations in your head :-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |