lkml.org 
[lkml]   [2004]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-2.4.26 released
Hi William,

On Tue, Apr 20, 2004 at 04:23:12PM -0700, William Lee Irwin III wrote:
> - return (mps_cpu/4)*16 + (1<<(mps_cpu%4));
> + return (mps_cpu & ~0x3) << 2 | 1 << (mps_cpu & 0x3);
^^^^
I think you wanted to put '<< 4' here instead of '<< 2'. Also, could you
put (useless for some) parenthesis to group the left side and the right
side of the bit-wise OR ? I'm always scared that someone changes it to
an addition with good intentions and changes the operators precedence
without noticing.

Cheers,
Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [W:0.043 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site