Messages in this thread | | | Date | Mon, 19 Apr 2004 17:11:22 +0100 | From | Russell King <> | Subject | Re: [PATCH] Clean up asm/pgalloc.h include (s390) |
| |
On Mon, Apr 19, 2004 at 05:56:19PM +0200, Martin Schwidefsky wrote: > > This patch cleans up needless includes of asm/pgalloc.h from the > > arch/s390/ subtree. This has not been compile tested, so > > needs the architecture maintainers (or willing volunteers) to > > test. > > Doesn't compile. s390_ksyms needs pgalloc.h for the definition of diag10. > The other includes of pgalloc.h can be removed without a problem.
Alternatively, could the diag10() prototype be moved somewhere else (tlbflush or cacheflush?) Is diag10 a tlb or cache function? It isn't clear from the code what diag10() does.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |