Messages in this thread Patch in this message | | | Date | Sun, 18 Apr 2004 12:32:41 +0100 | From | Christoph Hellwig <> | Subject | Re: Bug#244207: kernel-source-2.6.5: mwave gives warning on suspend |
| |
On Sun, Apr 18, 2004 at 12:17:55PM +0100, Christoph Hellwig wrote: > It's still bogus. The driver gets the sysfs support completely wrong > and the right thing would be to find that change in the BK history and > back it out.
Here's a patch to #if 0 out all the crap:
--- 1.12/drivers/char/mwave/mwavedd.c Wed Sep 10 08:41:45 2003 +++ edited/drivers/char/mwave/mwavedd.c Sun Apr 18 13:31:22 2004 @@ -466,6 +466,7 @@ static struct miscdevice mwave_misc_dev = { MWAVE_MINOR, "mwave", &mwave_fops }; +#if 0 /* totally b0rked */ /* * sysfs support <paulsch@us.ibm.com> */ @@ -499,6 +500,7 @@ &dev_attr_uart_irq, &dev_attr_uart_io, }; +#endif /* * mwave_init is called on module load @@ -508,11 +510,11 @@ */ static void mwave_exit(void) { - int i; pMWAVE_DEVICE_DATA pDrvData = &mwave_s_mdd; PRINTK_1(TRACE_MWAVE, "mwavedd::mwave_exit entry\n"); +#if 0 for (i = 0; i < pDrvData->nr_registered_attrs; i++) device_remove_file(&mwave_device, mwave_dev_attrs[i]); pDrvData->nr_registered_attrs = 0; @@ -521,6 +523,7 @@ device_unregister(&mwave_device); pDrvData->device_registered = FALSE; } +#endif if ( pDrvData->sLine >= 0 ) { unregister_serial(pDrvData->sLine); @@ -638,6 +641,7 @@ } /* uart is registered */ +#if 0 /* sysfs */ memset(&mwave_device, 0, sizeof (struct device)); snprintf(mwave_device.bus_id, BUS_ID_SIZE, "mwave"); @@ -655,6 +659,7 @@ } pDrvData->nr_registered_attrs++; } +#endif /* SUCCESS! */ return 0; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |