lkml.org 
[lkml]   [2004]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Fix unix module
From
Date
On Sun, 2004-04-18 at 18:01, Russell King wrote:
> On Sun, Apr 18, 2004 at 03:32:42PM +1000, Rusty Russell wrote:
> > The compiler #define's unix to 1: we use -DKBUILD_MODNAME=unix. We
> > used to #undef unix at the top of af_unix.c, but now the name is
> > inserted by modpost, that doesn't help.
>
> Do we depend on this preprocessor symbol anywhere? If not, adding
> -Uunix to the global CFLAGS would prevent future "accidents".

I don't really mind which way it's done, but this was the direct
translation of the previous fix, so required less testing.

Hopefully noone will ever call their module "linux", "i386" or
"__OPTIMIZE__" 8)

Cheers,
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [W:0.025 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site