Messages in this thread Patch in this message | | | Date | Fri, 16 Apr 2004 18:09:23 -0400 | Subject | Re: NFS thinko | From | "J. Bruce Fields" <> |
| |
On Fri, Apr 16, 2004 at 10:16:28PM +0100, Dave Jones wrote: > Dereferencing 'exp' before the check for NULL.
It would be a bug if exp were ever NULL there. Better just to delete that check entirely.
--Bruce Fields
If ek = exp_find_key() is not an error, then ek->ek_export should be set; no point in checking if it's NULL.
include/linux/nfsd/export.h | 3 +-- 1 files changed, 1 insertion(+), 2 deletions(-)
diff -puN include/linux/nfsd/export.h~export_exp_deref_fix include/linux/nfsd/export.h --- linux-2.6.6-rc1/include/linux/nfsd/export.h~export_exp_deref_fix 2004-04-16 17:51:57.000000000 -0400 +++ linux-2.6.6-rc1-bfields/include/linux/nfsd/export.h 2004-04-16 17:58:30.000000000 -0400 @@ -120,8 +120,7 @@ exp_find(struct auth_domain *clp, int fs int err; cache_get(&exp->h); expkey_put(&ek->h, &svc_expkey_cache); - if (exp && - (err = cache_check(&svc_export_cache, &exp->h, reqp))) + if ((err = cache_check(&svc_export_cache, &exp->h, reqp))) exp = ERR_PTR(err); return exp; } else _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |