Messages in this thread Patch in this message | | | Date | Fri, 16 Apr 2004 22:50:37 +0100 | From | Dave Jones <> | Subject | Re: rcpci45 dereference fix. |
| |
On Fri, Apr 16, 2004 at 10:45:06PM +0200, Francois Romieu wrote:
> rcpci45_init_one() must succeed in order for rcpci45_remove_one() to be > issued. > > If rcpci45_init_one() succeeds, dev can not be NULL. > > So I'd rather see the "if (!dev) {" test removed instead of this change.
Sure.
Dave
--- drivers/net/rcpci45.c~ 2004-04-16 22:22:22.000000000 +0100 +++ drivers/net/rcpci45.c 2004-04-16 22:49:54.000000000 +0100 @@ -131,12 +131,6 @@ struct net_device *dev = pci_get_drvdata (pdev); PDPA pDpa = dev->priv; - if (!dev) { - printk (KERN_ERR "%s: remove non-existent device\n", - dev->name); - return; - } - RCResetIOP (dev); unregister_netdev (dev); free_irq (dev->irq, dev); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |