Messages in this thread | | | Date | Fri, 16 Apr 2004 13:24:10 -0500 | From | Brian King <> | Subject | Re: [PATCH][RELEASE]: megaraid unified driver version 2.20.0.B1 |
| |
Jeff Garzik wrote: > 6) Kill uses of "volatile". _Most_ of the time, this indicates buggy > code. You should have the proper barriers in place: mb(), wmb(), > rmb(), barrier(), and cpu_relax(). This has been mentioned before :)
I'm not sure I totally agree with this statement. I took a quick look at the driver and the volatile appears to be used to point to host memory that is modified by the adapter. Correct me if I am wrong, but memory barriers will not accomplish what the volatile will in this situation.
-- Brian King eServer Storage I/O IBM Linux Technology Center
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |