Messages in this thread | | | Date | Fri, 16 Apr 2004 12:55:25 -0500 | From | Brian King <> | Subject | Re: [PATCH] call_usermodehelper hang |
| |
I applied and tested the new patches in the mm tree and it works fine for me.
Thanks
-Brian
Andrew Morton wrote: > Brian King <brking@us.ibm.com> wrote: > >>>>Ok, you've convinced me of the mess that would cause. So what should we >>> >> >> do to help fix this? Serialize call_usermodehelper()? >> > >> > >> > May as well bring back call_usermodehelper_async() I guess. >> > >> > >> > There are two patches here, and they are totally untested... >> >> I loaded the patches on my ppc64 box and they worked fine after I fixed a compile >> bug. The attached patch fixes the compile bug and changes the call_usermodehelper >> call in kset_hotplug to call_usermodehelper_async. > > > yup, thanks. I've changed the patch in my tree so that we always perform > the fully-async operation if call_usermodehelper() is passed "wait=0". It > gets the new code some more testing and keeps the kernel API simpler. > >
-- Brian King eServer Storage I/O IBM Linux Technology Center
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |