Messages in this thread Patch in this message | | | Subject | Re: [PATCH] I2C update for 2.6.5 | Date | Wed, 14 Apr 2004 15:24:09 -0700 | From | Greg KH <> |
| |
ChangeSet 1.1643.36.4, 2004/03/25 10:51:45-08:00, khali@linux-fr.org
[PATCH] I2C: initialize fan_mins in w83781d, asb100 and lm78
Quoting myself:
> While testing, I found a corner case that isn't handled properly. It > doesn't seem to be handled by the lm78 and the asb100 either. Setting > fanN_div before ever reading from the chip or setting fanN_min will > make use of fanN_min while it was never initialized.
The following patch addesses the issue. Tested to work on my AS99127F rev.1 (which means that only the changes to the w83781d driver were actually tested). Testers welcome.
drivers/i2c/chips/asb100.c | 5 +++++ drivers/i2c/chips/lm78.c | 6 ++++++ drivers/i2c/chips/w83781d.c | 6 ++++++ 3 files changed, 17 insertions(+)
diff -Nru a/drivers/i2c/chips/asb100.c b/drivers/i2c/chips/asb100.c --- a/drivers/i2c/chips/asb100.c Wed Apr 14 15:14:44 2004 +++ b/drivers/i2c/chips/asb100.c Wed Apr 14 15:14:44 2004 @@ -807,6 +807,11 @@ /* Initialize the chip */ asb100_init_client(new_client); + /* A few vars need to be filled upon startup */ + data->fan_min[0] = asb100_read_value(new_client, ASB100_REG_FAN_MIN(0)); + data->fan_min[1] = asb100_read_value(new_client, ASB100_REG_FAN_MIN(1)); + data->fan_min[2] = asb100_read_value(new_client, ASB100_REG_FAN_MIN(2)); + /* Register sysfs hooks */ device_create_file_in(new_client, 0); device_create_file_in(new_client, 1); diff -Nru a/drivers/i2c/chips/lm78.c b/drivers/i2c/chips/lm78.c --- a/drivers/i2c/chips/lm78.c Wed Apr 14 15:14:44 2004 +++ b/drivers/i2c/chips/lm78.c Wed Apr 14 15:14:44 2004 @@ -625,6 +625,12 @@ /* Initialize the LM78 chip */ lm78_init_client(new_client); + /* A few vars need to be filled upon startup */ + for (i = 0; i < 3; i++) { + data->fan_min[i] = lm78_read_value(new_client, + LM78_REG_FAN_MIN(i)); + } + /* Register sysfs hooks */ device_create_file(&new_client->dev, &dev_attr_in0_input); device_create_file(&new_client->dev, &dev_attr_in0_min); diff -Nru a/drivers/i2c/chips/w83781d.c b/drivers/i2c/chips/w83781d.c --- a/drivers/i2c/chips/w83781d.c Wed Apr 14 15:14:44 2004 +++ b/drivers/i2c/chips/w83781d.c Wed Apr 14 15:14:44 2004 @@ -1252,6 +1252,12 @@ /* Initialize the chip */ w83781d_init_client(new_client); + /* A few vars need to be filled upon startup */ + for (i = 1; i <= 3; i++) { + data->fan_min[i - 1] = w83781d_read_value(new_client, + W83781D_REG_FAN_MIN(i)); + } + /* Register sysfs hooks */ device_create_file_in(new_client, 0); if (kind != w83783s && kind != w83697hf) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |