lkml.org 
[lkml]   [2004]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Linux 2.4.26-rc2
Marcelo Tosatti wrote:
> Hi,
>
> Here goes the second release candidate. It contains an ACPI update,
> networking updates, IDE updates, XFS update, etc.

Building the (binary) nvidia driver I got this warning:

In file included from /lib/modules/2.4.26-rc2/build/include/linux/vmalloc.h:8,
from nv-linux.h:62,
from os-interface.c:26:
/lib/modules/2.4.26-rc2/build/include/linux/highmem.h: In function `bh_kmap':
/lib/modules/2.4.26-rc2/build/include/linux/highmem.h:20: warning: pointer of type `void *' used in arithmetic

Looking there I see:

static inline char *bh_kmap(struct buffer_head *bh)
{
return kmap(bh->b_page) + bh_offset(bh);
}

And in /usr/include/linux/highmem.h I see:

static inline void *kmap(struct page *page) { return page_address(page); }

So we really are doing 'void *' math, which is not right. Maybe a cast is
called for in bh_kmap(), like:
return (char *)kmap(bh->b_page) + bh_offset(bh);

--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [W:0.035 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site