Messages in this thread | | | Date | Thu, 1 Apr 2004 17:36:49 -0800 | From | Andrew Morton <> | Subject | Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix |
| |
Andrea Arcangeli <andrea@suse.de> wrote: > > > it isn't doing anything useful for rw_swap_page_sync, just getting you > > into memory allocation difficulties. No need for add_to_page_cache or > > add_to_swap_cache there at all. As I say, I haven't tested this path, > > I wouldn't need to call add_to_page_cache either, it's just Andrew > prefers it.
Well all of this is to avoid a fairly arbitrary BUG_ON in the radix-tree code. If I hadn't added that, we'd all be happy.
The code is well-tested and has been thrashed to death in the userspace radix-tree test harness. (http://www.zip.com.au/~akpm/linux/patches/stuff/rtth.tar.gz). Let's remove the BUG_ON. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |