lkml.org 
[lkml]   [2004]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PnP BIOS exception fixes
Linus Torvalds wrote:
>
> On Thu, 4 Mar 2004, Brian Gerst wrote:
>
>>This patch fixes two errors in fixup_exception() for PnP BIOS faults:
>>- Check for the correct segments used for the BIOS
>>- Fix asm constraints so that EIP and ESP are properly reloaded
>
>
> I'm almost certain that you should NOT use "g" as a constraint, since that
> allows the address to be on the stack frame, so when we compile without
> frame pointers and the compiler uses a %esp-relative thing for the branch
> address, that will totally screw up when we just re-loaded %esp inside the
> asm.
>
> Can you use "r" instead, and test that it all works for you, and send an
> updated patch? Or just explain why I'm wrong.
>
> Linus
>

The inputs are global variables, with absolute addresses.

--
Brian Gerst
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.026 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site