Messages in this thread | | | Date | Tue, 30 Mar 2004 16:28:50 -0800 | From | Andrew Morton <> | Subject | Re: 2.6.5-rc3-mm1 |
| |
Greg KH <greg@kroah.com> wrote: > > On Tue, Mar 30, 2004 at 02:34:37AM -0800, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.5-rc3/2.6.5-rc3-mm1/ > > > > - Dropped the tty locking fix. As predicted, it deadlocked. I also > > reverted the patch from bk-driver-core.patch which is causing this race to > > trigger more frequently. > > Argh, so the only way I'm going to be able to get my little, tiny, > simple vc class patch is by fixing all of the tty layer locking code?
Well the good news is that my test box now oopses on about 2-out-of-3 boot attempts. But that gets tiresome.
> Ugh, that's so mean... :)
Optimistic, too.
I'm thinking that this can be fixed from the other direction: just before release_dev() calls close (dropping BKL), if tty->count==1, make the going-away tty ineligible for concurrent lookups. Do that by setting tty->driver->ttys[idx] to NULL. Maybe. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |