Messages in this thread | | | Date | Fri, 26 Mar 2004 11:19:45 -0700 | From | Tom Rini <> | Subject | Re: [PATCH] asm-ppc/elf.h warning |
| |
On Fri, Mar 26, 2004 at 08:00:06PM +0200, Meelis Roos wrote:
> > Can you try just removing <linux/elf.h> from everything in > > arch/ppc/boot/ ? > > elf.h include is present in arch/ppc/boot/simple/misc.c and > arch/ppc/boot/simple/misc-embedded.c. The first one caused my warning > and the include can be safely removed from there. The other file is not > used in my config (prep) but I did try to compile it with elf.h include > removed (make arch/ppc/boot/simple/misc-embedded.o) and it failed. So > here is the patch against arch/ppc/boot/simple/misc.c.
Ok, I'll look into that myself.
> Nevertheless, > asm-ppc/elf.h can not be included by itself without a warning about > struct task_struct - is this a problem or not?
It depends on if (a) other arches have a task_struct-needing extern in this file and (b) what do they do? There's at least a few #includes with implicit #include requirements out there, i _think_.
-- Tom Rini http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |