lkml.org 
[lkml]   [2004]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 3/22] __early_param for ppc
trini@kernel.crashing.org writes:

> -#ifdef CONFIG_XMON
> - xmon_map_scc();
> - if (strstr(cmd_line, "xmon"))
> - xmon(0);
> -#endif /* CONFIG_XMON */
...
> +/* Allow us a hook to drop in early. */
> +static void __init early_xmon(char **ign)
> +{
> + xmon_map_scc();
> + xmon(0);
> +}
> +__early_param("xmon", early_xmon);

You have changed the behaviour here, in that now xmon_map_scc() only
gets called if you put xmon on the command line, whereas previously it
got called unconditionally (assuming CONFIG_XMON=y). Did you check
whether this will cause problems?

Regards,
Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.019 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site