Messages in this thread | | | Date | Mon, 15 Mar 2004 08:55:13 +0100 | From | Herbert Poetzl <> | Subject | Re: [PATCH] Bind Mount Extensions 0.04 (linux-2.6.4) |
| |
On Sun, Mar 14, 2004 at 08:34:27PM -0800, Andrew Morton wrote: > Herbert Poetzl <herbert@13thfloor.at> wrote: > > On Sun, Mar 14, 2004 at 08:14:57PM -0800, Andrew Morton wrote: > > > > > > This won't apply any more. We very recently changed a large > > > number of filesystems to not call update_atime() from within > > > their readdir functions. > > > That operation was hoisted up to vfs_readdir().
okay, patches do reflect this change now ...
> > > Also, rather than adding MNT_IS_RDONLY() and having to > > > remember to check both the inode and the mount all over > > > the kernel it would be better to change IS_RDONLY() to > > > take two arguments - the inode and the vfsmnt. That > > > way we won't miss places, and unconverted code simpy > > > won't compile, thus drawing attention to itself. > > > I don't know if this is feasible, but please consider it.
I decided to split this up into five parts, a simple base patch, a patch doing the noatime stuff, and three patches for the IS_RDONLY changes ...
bme0.04.1-ro1 ... are the completely resolved ones bme0.04.1-ro2 ... acl stuff, needs checking for nd bme0.04.1-ro3 ... unresolved/legacy
currently I do not know where to get the vfsmnt for the cases in bme0.04.1-ro3, so they use the legacy define IS_RDONLY_INODE() for their checks ...
I hope this is what you had in mind, but anyways, let me know how to proceed ...
best, Herbert
PS: basic functionality has been verified.
http://www.13thfloor.at/patches/patch-2.6.4-20040314_2308-bme0.04.1.diff http://www.13thfloor.at/patches/patch-2.6.4-20040314_2308-bme0.04.1-atime.diff http://www.13thfloor.at/patches/patch-2.6.4-20040314_2308-bme0.04.1-ro1.diff http://www.13thfloor.at/patches/patch-2.6.4-20040314_2308-bme0.04.1-ro2.diff http://www.13thfloor.at/patches/patch-2.6.4-20040314_2308-bme0.04.1-ro3.diff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |