Messages in this thread | | | Date | Sun, 14 Mar 2004 01:07:24 -0800 | From | William Lee Irwin III <> | Subject | Re: [Lse-tech] Re: Hugetlbpages in very large memory machines....... |
| |
On Sun, Mar 14, 2004 at 12:57:37AM -0800, Andrew Morton wrote: > Well that's just a dumb implementation. hugetlb_prefault() doesn't need > page_table_lock while it is zeroing the page: just drop it, test for > -EEXIST returned from add_to_page_cache(). > In fact we need to do that anyway: the current code is buggy if some other > process with a different mm gets in there and instantiates the page in the > pagecache before this process does: hugetlb_prefault() will return -EEXIST > instead of simply accepting the race and using the page which someone else > put there.
Don't blame me. I didn't write the expand-on-mmap() code.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |