Messages in this thread Patch in this message | | | Date | Fri, 27 Feb 2004 22:44:50 -0800 | From | Greg KH <> | Subject | Re: 2.6.3-bk9 QA testing: firewire good, USB printing dead |
| |
On Fri, Feb 27, 2004 at 07:57:32PM -0700, Daniel Robbins wrote: > > With 2.6.3-bk9, I also had a block of two mainboard USB ports simply > stop functioning -- to the point of even no longer sending power to the > USB hub that I was using.
That's not good. Are these real usb 2.0 printers? Can you run them in 1.1 mode instead (just don't load the ehci-hcd driver)?
If that also fails, here's the only usblp patch in 2.6.3-bk9. If you revert it, does that solve the problem?
thanks,
greg k-h
diff -Nru a/drivers/usb/class/usblp.c b/drivers/usb/class/usblp.c --- a/drivers/usb/class/usblp.c Fri Feb 27 22:42:31 2004 +++ b/drivers/usb/class/usblp.c Fri Feb 27 22:42:31 2004 @@ -603,7 +603,7 @@ { DECLARE_WAITQUEUE(wait, current); struct usblp *usblp = file->private_data; - int timeout, err = 0; + int timeout, err = 0, transfer_length; size_t writecount = 0; while (writecount < count) { @@ -654,19 +654,13 @@ continue; } - writecount += usblp->writeurb->transfer_buffer_length; - usblp->writeurb->transfer_buffer_length = 0; + transfer_length=(count - writecount); + if (transfer_length > USBLP_BUF_SIZE) + transfer_length = USBLP_BUF_SIZE; - if (writecount == count) { - up (&usblp->sem); - break; - } + usblp->writeurb->transfer_buffer_length = transfer_length; - usblp->writeurb->transfer_buffer_length = (count - writecount) < USBLP_BUF_SIZE ? - (count - writecount) : USBLP_BUF_SIZE; - - if (copy_from_user(usblp->writeurb->transfer_buffer, buffer + writecount, - usblp->writeurb->transfer_buffer_length)) { + if (copy_from_user(usblp->writeurb->transfer_buffer, buffer + writecount, transfer_length)) { up(&usblp->sem); return writecount ? writecount : -EFAULT; } @@ -683,6 +677,8 @@ break; } up (&usblp->sem); + + writecount += transfer_length; } return count; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |