Messages in this thread | | | Subject | Re: kernel/microcode.c error from new 64bit code | From | (Eric W. Biederman) | Date | 21 Feb 2004 12:30:34 -0700 |
| |
Linus Torvalds <torvalds@osdl.org> writes:
> On Sat, 21 Feb 2004, Eric W. Biederman wrote: > > > > What is wrong with the original? > > > > - wrmsr(MSR_IA32_UCODE_WRITE, (unsigned int)(uci->mc->bits), 0); > > > > I don't see how anything else could be correct. > > Did you miss the fact that we now support x86-64, and that if compiled > that way the address is 64-bit?
No I missed the fact that uci->mc->bits was an address. Now it makes sense how we can have a 64bit value only in 64bit mode....
The code still feels a little awkward but after looking at it some more I don't see any problems.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |