Messages in this thread | | | Date | Tue, 7 Dec 2004 12:46:15 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH/RFC] Add support to resume swsusp from initrd |
| |
Hi!
> > > - > > > +extern dev_t swsusp_resume_device; > > > > > > static int noresume = 0; > > > char resume_file[256] = CONFIG_PM_STD_PARTITION; > > > > Move it to include/linux/suspend.h > > swsusp_resume_device? Ok.
Yes.
> > > + p = memchr(buf, '\n', n); > > > + len = p ? p - buf : n; > > > + > > > + if (sscanf(buf, "%u:%u", &maj, &min) == 2) { > > > + res = MKDEV(maj, min); > > > + if (maj == MAJOR(res) && min == MINOR(res)) { > > > > You mkdev, than test that MKDEV worked? Could you add a comment why > > its needed? > > That's just cut and pasted from name_to_dev_t - I assumed there was some > subtlety going on there.
Ok, maybe there's some subtlety ;-). If someone knows, please comment... Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |