lkml.org 
[lkml]   [2004]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6] clean-up: fixes "comparison between signed
On Tue, 7 Dec 2004, Petr Vandrovec wrote:

> On Tue, Dec 07, 2004 at 12:09:05AM +0100, Jesper Juhl wrote:
> > On Mon, 6 Dec 2004, Petr Vandrovec wrote:
> > > Correct is (if any fix is needed at all) typecast regs->esp to unsigned
> > > long,
> >
> > That would have been my suggestion as well.
> >
> > >eventually with check that address is less than (unsigned long)-32,
> > > as area at VA 0 is not going to grow "down" to 0xFFFFFxxx, even if you
> > > nicely ask.
> >
> > you mean something like this - right?
>
> Yes. Though I believe that we already take vma == NULL path when address is that big.

Hmm, where? - maybe I'm blind or just stupid, but I don't seem to be able
to find where we do that.
And would it hurt to have that additional check there as well in case
address was modified after the previous check and before being passed to
do_page_fault ? (note: I'm writing this last bit without having mined the
source for info yet).

--
Jesper


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.063 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site