lkml.org 
[lkml]   [2004]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARCH_SLAB_MINALIGN for 2.6.10-rc3
Hi Manfred,

On Mon, Dec 06, 2004 at 11:15:20PM +0100, Manfred Spraul wrote:
> With your patch, ARCH_SLAB_MINALIGN is not a hard limit: A few lines
> further down align is reset to word size if SLAB_RED_ZONE is set. I
> don't like the asymmetry - it just asks for trouble.
>
Yes, that's true. I don't see much of a point in leaving it as
BYTES_PER_WORD in the SLAB_RED_ZONE case, at least this wasn't
intentional. Would you accept ARCH_SLAB_MINALIGN if this was set
regardless of whether SLAB_RED_ZONE is set or not?

I suppose we can live with align being 0 in the CONFIG_DEBUG_SLAB
case as the unaligned accesses are not fatal..
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.059 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site