Messages in this thread Patch in this message | | | From | Parag Warudkar <> | Subject | Re: [PATCH] Document kfree and vfree NULL usage (resend) | Date | Sun, 5 Dec 2004 13:12:53 -0500 |
| |
Ok. So need for changing vmalloc() documentation then.
Here is the same previous patch inline instead of the attachment, with Signed-off-by -
(Sorry this is my first patch !)
Parag
Signed-off-by: Parag Warudkar <kernel-stuff@comcast.net>
--- linux-mod/mm/vmalloc.c.orig 2004-12-05 12:40:50.699631616 -0500 +++ linux-mod/mm/vmalloc.c 2004-12-05 12:37:17.279076472 -0500 @@ -340,7 +340,7 @@ void __vunmap(void *addr, int deallocate * Free the virtually contiguous memory area starting at @addr, as * obtained from vmalloc(), vmalloc_32() or __vmalloc(). * - * May not be called in interrupt context. + * Must not be called in interrupt context. */ void vfree(void *addr) { On Sunday 05 December 2004 12:57 pm, Manfred Spraul wrote: > Kernel Stuff wrote: > > >The attached patch changes the vfree() documentation to correct "May not be > >called in interrupt context" to "Must not be called in interrupt context". > >Latter is compliant to RFC2119 and matches the absolute requirement for > >vfree. > > > >Is not the same requirement true for vmalloc() - or is it ok to call vmalloc() > >in interrupt? > > > > > > > No, it's not ok. > But that's not something worth mentioning: only a few functions are > permitted from interrupt context. The special thing about vfree is the > asymmetry: kfree from irq context is ok, vfree is forbidden. That's why > it's documented. > > -- > Manfred > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > [unhandled content-type:application/pgp-signature] | |