lkml.org 
[lkml]   [2004]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] NX: Fix noexec kernel parameter / x86_64
On Sun, 5 Dec 2004, Ingo Molnar wrote:

>
> * Zwane Mwaikambo <zwane@arm.linux.org.uk> wrote:
>
> > + if (!memcmp(from, "noexec=", 7)) {
> > + extern void nonx_setup(char *str);
> > +
> > + nonx_setup(from + 7);
> > + }
>
> looks good, but please put the prototype into a header.

I bet Andrew is going to say the same thing... It just seems odd putting a
prototype in a header for a function with one call site and gets freed
after boot. Since i'll have to rediff, i'm also going to change the
nonx_setup parameter type to const char * as suggested by someone in a
private email.

Thanks,
Zwane

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.328 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site