Messages in this thread | | | Date | Fri, 31 Dec 2004 10:10:45 -0500 | From | Daniel Jacobowitz <> | Subject | Re: ptrace single-stepping change breaks Wine |
| |
On Thu, Dec 30, 2004 at 09:47:42PM -0800, Linus Torvalds wrote: > So I looked at just sharing the code with the debug trap handler, and the > result is appended. strace works, as does all the TF tests I've thrown at > it, and the code actually looks better anyway (the old do_debug code looks > like it got the EIP wrong in VM86 mode, for example, this just cleans > that up too). Just use a common "send_sigtrap()" routine. > > Does this look saner?
Lots, I like it. The syscall trap will always be delivered before the single-step trap, right, because signal delivery won't run until we return to userspace?
-- Daniel Jacobowitz - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |