Messages in this thread | | | Date | Wed, 29 Dec 2004 19:06:24 +0000 | From | Christoph Hellwig <> | Subject | Re: [BK PATCH] fix floppy build |
| |
On Wed, Dec 29, 2004 at 02:02:12PM -0500, Jeff Garzik wrote: > So my patch removing #include kernel/version.h broke the modular floppy > build... doh. I would prefer to remove the redundancy of listing the > kernel version each time the floppy driver is loaded. > > See attached for 'bk pull' and example patch.
> Please do a > > bk pull bk://gkernel.bkbits.net/misc-2.6 > > This will update the following files: > > drivers/block/floppy.c | 2 +- > 1 files changed, 1 insertion(+), 1 deletion(-) > > through these ChangeSets: > > <jgarzik@pobox.com> (04/12/29 1.2079) > block/floppy.c: fix build by removing UTS_RELEASE use > > It's redundant to the kernel message that prints out the kernel version, > as well as many other places where one can request the kernel version. > > diff -Nru a/drivers/block/floppy.c b/drivers/block/floppy.c > --- a/drivers/block/floppy.c 2004-12-29 14:00:55 -05:00 > +++ b/drivers/block/floppy.c 2004-12-29 14:00:55 -05:00 > @@ -4595,7 +4595,7 @@ > > int init_module(void) > { > - printk(KERN_INFO "inserting floppy driver for " UTS_RELEASE "\n"); > + printk(KERN_INFO "inserting floppy driver\n");
or just kill the printk completely..
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |