Messages in this thread | | | Date | Mon, 27 Dec 2004 23:20:37 +0800 | From | Bernard Blackham <> | Subject | Re: [PATCH] sched-fix-scheduling-latencies-in-mttrc reenables interrupts |
| |
On Mon, Dec 27, 2004 at 01:36:53AM -0800, Andrew Morton wrote: > Not OK. That global `sal_flags' is not protected by the spinlock > because spin_lock_irqsave() saves the flags before taking the > lock.
Ahh, d'oh.
> How about this? > > diff -puN arch/i386/kernel/cpu/mtrr/generic.c~sched-fix-scheduling-latencies-in-mttrc-reenables-interrupts arch/i386/kernel/cpu/mtrr/generic.c
Won't object here.
Thanks,
Bernard.
-- Bernard Blackham <bernard at blackham dot com dot au> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |