Messages in this thread | | | Date | Mon, 27 Dec 2004 16:06:18 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] Twibright I2C2P driver |
| |
Hi!
> I have just published Twibright I2C2P: > > * I2C interface (adaptor) for parallel port > * Free technology electronics device > * Bidirectional: Both SDA and SCL are bidirectional > * Optically isolated > * Powered from parallel port > * Driver for Linux kernel
Its quite short. Did you forget to attach actual c source? Or is it this simple?
> @@ -140,7 +141,11 @@ > .getscl = parport_getscl, > .udelay = 60, > .mdelay = 60, > - .timeout = HZ, > + .timeout = (HZ+99)/100, > + /* This is 10ms. Parport adapter of type 6 may be > + * powered down which introduces 90sec delay to > + * machine boot. I consider 10ms to be sufficient for
90msec?
> + * the parport adapter timeout. --Clock */
Avoid signing comments like this. Neccessary info is in bitkeeper logs anyway. > @@ -38,6 +38,9 @@ > struct lineop getsda; > struct lineop getscl; > struct lineop init; > + struct lineop init2; /* Added by Clock */
and this.
Pavel -- 64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |