lkml.org 
[lkml]   [2004]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [discuss] Re: unregister_ioctl32_conversion and modules. ioctl32 revisited.
Date
On Sünndag 26 Dezember 2004 23:26, Chris Wedgwood wrote:
> > It's an internal error code as Arnd pointed out.
>
> can we be sure this will never escape to userspace?  i can think of
> somewhere else we already do this (EFSCORRUPTED) and it does (somewhat
> deliberately escape to userspace) and this causes confusion from time
> to time when applications see 'errno == 990'

It's safe for the compat ioctl case. If someone wants to use the
same function for the compat and native handler, it would be a bug
to return -ENOIOCTLCMD from that handler with the current code.

To work around this, we could either convert -ENOIOCTLCMD to -EINVAL
when returning from sys_ioctl(). Or we could WARN_ON(err == -ENOIOCTLCMD)
for the native path in order to make the intention clear.

Arnd <><
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 14:09    [W:0.108 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site