Messages in this thread Patch in this message | | | Date | Mon, 27 Dec 2004 23:50:15 +0100 | From | Adrian Bunk <> | Subject | [2.6 patch] add missing dependencies on MTD_PARTITIONS |
| |
On Tue, Dec 28, 2004 at 12:23:48AM +0200, Michael S. Tsirkin wrote:
> Hello!
Hi Michael!
> Sorry, I had a wrong subject. > > It seems that you can disable MTD partitioning support > but enable , e.g. NAND. > And, if you are upgrading from and older kernel without > the paritioning option, and do oldconfig and are not careful, > thats what you end up with. > But, lots of code is calling del_mtd_partitions now, so you get > unresolved del_mtd_partitions. > > Its easy to work around this by enabling partitioning, but > should not the dependency be added in the relevant KConfig?
First of all thanks for your report. You didn't send the exact error mesage. I'm able to reproduce the following in 2.6.10-rc3-mm1:
<-- snip -->
... LD .tmp_vmlinux1 drivers/built-in.o(.init.text+0x6464b): In function `init_scx200_docflash': : undefined reference to `add_mtd_partitions' drivers/built-in.o(.init.text+0x66ab8): In function `ns_init_module': : undefined reference to `add_mtd_partitions' drivers/built-in.o(.exit.text+0x8bf4): In function `cleanup_scx200_docflash': : undefined reference to `del_mtd_partitions' make: *** [.tmp_vmlinux1] Error 1
<-- snip -->
The patch below fixes them.
Please tell whether this fixes the problems you observed.
> Cc me directly, I'm not on the list. > Thanks, > MST
cu Adrian
diffstat output: drivers/mtd/maps/Kconfig | 2 +- drivers/mtd/nand/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc3-mm1-full/drivers/mtd/maps/Kconfig.old 2004-12-27 23:43:00.000000000 +0100 +++ linux-2.6.10-rc3-mm1-full/drivers/mtd/maps/Kconfig 2004-12-27 23:44:01.000000000 +0100 @@ -159,7 +159,7 @@ config MTD_SCx200_DOCFLASH tristate "Flash device mapped with DOCCS on NatSemi SCx200" - depends on X86 && MTD_CFI + depends on X86 && MTD_CFI && MTD_PARTITIONS help Enable support for a flash chip mapped using the DOCCS signal on a National Semiconductor SCx200 processor. --- linux-2.6.10-rc3-mm1-full/drivers/mtd/nand/Kconfig.old 2004-12-27 23:44:44.000000000 +0100 +++ linux-2.6.10-rc3-mm1-full/drivers/mtd/nand/Kconfig 2004-12-27 23:45:37.000000000 +0100 @@ -198,7 +198,7 @@ config MTD_NAND_NANDSIM bool "Support for NAND Flash Simulator" - depends on MTD_NAND + depends on MTD_NAND && MTD_PARTITIONS help The simulator may simulate verious NAND flash chips for the - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |