Messages in this thread | | | Subject | Re: [PATCH] add PCI API to sysfs | From | Benjamin Herrenschmidt <> | Date | Tue, 21 Dec 2004 08:10:04 +0100 |
| |
> > +static int mmap(struct file *file, struct vm_area_struct *vma) > > +{
Also, just a style comment: I dislike when functions have such a "generic" name like mmap. I'd _much_ prefer something like pcisysfs_mmap or something like that. The simple name makes it confusing in System.map/kallsyms and thus when debugging.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |