Messages in this thread | | | Subject | Re: Scheduling while atomic (2.6.10-rc3-bk13) | From | Lee Revell <> | Date | Mon, 20 Dec 2004 15:57:43 -0500 |
| |
On Mon, 2004-12-20 at 11:52 -0800, David Brownell wrote: > On Monday 20 December 2004 10:48 am, Greg KH wrote: > > > > > David, it looks like you grab a spinlock, and then call msleep(20); > > which causes this warning. > > > > Care to fix it? > > How bizarre ... I must have been tested that without spinlock > debugging, for some reason. Grr. I usually leave that on, > just to prevent stuff like this. > > Here's a quick'n'dirty patch, msleep --> mdelay. I'd rather > not mdelay for that long, but this late in 2.6.10 it's safer. > (And this is also what OHCI does in that same code path.)
Ugh. 20ms is WAY too long to hold a spinlock. That's guaranteed to cause audio skips. Isn't there another way?
If OHCI calls mdelay(20) while holding a spinlock that needs to be fixed.
Lee
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |