lkml.org 
[lkml]   [2004]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Coverity] Untrusted user data in kernel
Oliver Neukum wrote:
>>But the difference between you example (cp /dev/zero /dev/mem) and
>>passing unchecked data to the kernel is... you _can_ check the data and
>
>
> This is the difference:
> static int open_port(struct inode * inode, struct file * filp)
> {
> return capable(CAP_SYS_RAWIO) ? 0 : -EPERM;
> }
> (from mem.c)
>

OK, but my point was, whenever you can check the 'contents' of the data
passed to the kernel, do it. You can't check if the data someone writes
to /dev/mem is valid or not, but you can check for out-of-range/etc.
data in ioctl & friends.

tom

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.236 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site