lkml.org 
[lkml]   [2004]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Remove RCU abuse in cpu_idle()
On Sun, 12 Dec 2004, Andrew Morton wrote:

> > void cpu_idle (void)
> > {
> > + int cpu = smp_processor_id();
> > +
> > /* endless idle loop with no priority at all */
>
> This gives me scadzillions of "using smp_procesor_id() in preemptible"
> warnings.
>
> I'll shut that up with _smp_processor_id() but one does wonder what happens
> if we get preempted and `cpu' refers to some other CPU?

The idle thread is special in the sense that it can't get migrated so the
cached values of smp_processor_id are fine.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.116 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site