lkml.org 
[lkml]   [2004]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/5] NOMMU: Make POSIX shmem work on ramfs-backed files
Date
Ingo Oeser <ioe@axxeo.de> wrote:

> What about this pattern instead:
>
> file-mmu-y := file-mmu.o
> file-mmu-n := file-nommu.o
> file-mmu- := file-nommu.o
> ramfs-objs += file-mmu-$(CONFIG_MMU)
>
> Requires more work while writing it, but removes the ifeq,
> which should be avoided in makefiles as hell

Your suggestion adds duplicate information. This solution is worse than the
thing you're trying to fix.

Do we really need both the file-mmu-n and file-mmu- variants?

Actually, this would probably do instead:

file-mmu-y := file-nommu.o
file-mmu-$(CONFIG_MMU) := file-mmu.o
ramfs-objs := inode.o file-mmu-y

Will this work? Or should it be $(file-mmu-y) on the last line?

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.042 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site