Messages in this thread | | | Date | Tue, 09 Nov 2004 22:21:36 +0100 | From | Christian Kujau <> | Subject | Re: [PATCH] kobject: fix double kobject_put() in error path of kobject_add() |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Greg KH schrieb: > > Christian, I don't know if this patch explicitly fixes your problem, but > it fixes problems other people have been having with the driver core > lately. I'd appreciate it if you could test it out and let me know if > it solves your problem, with CONFIG_EDD enabled, or if it doesn't help > at all. >
yes, i'll do so and test the patch. is this in current -BK yet? because applying your patch [1] to 2.6.10-rc1 gives:
Hunk #1 FAILED at 181. 1 out of 1 hunk FAILED -- saving rejects to file lib/kobject.c.rej
i've done a few other things before, let me just post the results before i go on with your suggestions:
i've compiled a recent (BK) 2.6.10-rc1 again with CONFIG_EDD=m|y|n
http://www.nerdbynature.de/bits/prinz/2.6.10-rc1/config-2.6.10-rc1_edd-modular.txt http://www.nerdbynature.de/bits/prinz/2.6.10-rc1/config-2.6.10-rc1_edd.txt http://www.nerdbynature.de/bits/prinz/2.6.10-rc1/config-2.6.10-rc1_no-edd.txt
the results:
http://www.nerdbynature.de/bits/prinz/2.6.10-rc1/dmesg-2.6.10-rc1_edd-modular.txt http://www.nerdbynature.de/bits/prinz/2.6.10-rc1/dmesg-2.6.10-rc1_edd.txt http://www.nerdbynature.de/bits/prinz/2.6.10-rc1/dmesg-2.6.10-rc1_no-edd.txt
the interesting thing (for me) was, that when CONFIG_EDD=m was set, my sound card was working properly and i could do "modprobe edd" and "rmmod edd" as i like:
http://www.nerdbynature.de/bits/prinz/2.6.10-rc1/typescript-2.6.10-rc1_edd-modular.txt
again: i double checked and compiled on 2 different hosts, each having it's own -BK tree.
thanks, Christian.
[1] http://www.nerdbynature.de/bits/prinz/2.6.10-rc1/edd-fix.patch - -- BOFH excuse #22:
monitor resolution too high -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFBkTTg+A7rjkF8z0wRAvFPAKCCM05vqhg4u2NH2wklRRbxdVSpcwCff9a3 /KodSmgp9J4Nf2LDcTiBOCo= =B/3X -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |