Messages in this thread | | | Date | Mon, 8 Nov 2004 18:02:23 +0530 | From | Suparna Bhattacharya <> | Subject | Re: [PATCH] Fix O_SYNC speedup for generic_file_write_nolock |
| |
On Mon, Nov 08, 2004 at 01:05:44PM +0100, Arjan van de Ven wrote: > On Mon, 2004-11-08 at 17:23 +0530, Suparna Bhattacharya wrote: > > On Mon, Nov 08, 2004 at 11:04:38AM +0100, Arjan van de Ven wrote: > > > > +EXPORT_SYMBOL(sync_page_range_nolock); > > > > > > > > > why adding this export? nothing appears to be using it (AIO isn't a module after all) > > > > > > > This doesn't have anything to do with AIO. Filesystems which implement > > the equivalent of generic_file_write_nolock may use sync_page_range_nolock > > for O_SYNC. > > > > Does that help clarify ? > > not really; none do so far so how about not adding the export until > someone does use it ?
It is just like sync_page_range() from akpm's original O_SYNC speedup patch. Andrew, do we keep or remove the export ?
Regards Suparna
-- Suparna Bhattacharya (suparna@in.ibm.com) Linux Technology Center IBM Software Lab, India
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |