Messages in this thread | | | Date | Mon, 8 Nov 2004 12:13:01 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb |
| |
On Tue, 9 Nov 2004, Antonino A. Daplas wrote: > > In big endian machines, the read*/write* accessors do a byteswap for an > inherently little endian PCI bus. However, rivafb puts the hardwire in big > endian register access, thus the byteswap is not needed. So, instead of > read*/write*, use __raw_read*/__raw_write*.
This fix should make the #ifdef CONFIG_PCC entirely superfluous afaik.
The thing is, once riva does its HW accesses right, the special cases just go away. There's a reason we have abstractions..
Does anybody have the hardware to test with?
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |