Messages in this thread | | | Subject | Re: Externalize SLIT table | From | Andreas Schwab <> | Date | Fri, 05 Nov 2004 17:26:10 +0100 |
| |
Jack Steiner <steiner@sgi.com> writes:
> @@ -111,6 +111,21 @@ static ssize_t node_read_numastat(struct > } > static SYSDEV_ATTR(numastat, S_IRUGO, node_read_numastat, NULL); > > +static ssize_t node_read_distance(struct sys_device * dev, char * buf) > +{ > + int nid = dev->id; > + int len = 0; > + int i; > + > + for (i = 0; i < numnodes; i++) > + len += sprintf(buf + len, "%s%d", i ? " " : "", node_distance(nid, i));
Can this overflow the space allocated for buf?
> @@ -58,6 +59,31 @@ static inline void register_cpu_control( > } > #endif /* CONFIG_HOTPLUG_CPU */ > > +#ifdef CONFIG_NUMA > +static ssize_t cpu_read_distance(struct sys_device * dev, char * buf) > +{ > + int nid = cpu_to_node(dev->id); > + int len = 0; > + int i; > + > + for (i = 0; i < num_possible_cpus(); i++) > + len += sprintf(buf + len, "%s%d", i ? " " : "", > + node_distance(nid, cpu_to_node(i)));
Or this?
Andreas.
-- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |